BLD adding some tests & ENH new functions in wrapper#165
Open
Bidibulke wants to merge 6 commits intolava:masterfrom
Open
BLD adding some tests & ENH new functions in wrapper#165Bidibulke wants to merge 6 commits intolava:masterfrom
Bidibulke wants to merge 6 commits intolava:masterfrom
Conversation
TST * adding some unit tests using Catch2 framework * 6 test cases with 91 assertions. * normally there is a test for each function in matplotlibcpp.h * `class Plot` is not tested MISC According to numpy documentation: * BLD change related to building and installing (examples, module, …) * ENH enhancement * TST addition or modification of tests * ...
Author
|
It's the first step of bigger modifications. In a further pull request, I will modify |
commit 9047863bb0c1a34bc6473c2dadee720073db631e
Author: Claire Guilbaud <claire.guilbaud@cea.fr>
Date: Thu Mar 26 15:46:34 2020 +0100
@enh figure with variadic template args
commit a8a3dd018c14a5e5c98b084f566865ba936c4fec
Author: Claire Guilbaud <claire.guilbaud@cea.fr>
Date: Thu Mar 26 14:55:36 2020 +0100
@enh close
commit 6440609657de0f47b6fd4c1a8c213704f2810a4f
Author: Claire Guilbaud <claire.guilbaud@cea.fr>
Date: Thu Mar 26 13:41:18 2020 +0100
@enh generic form for scatter
In order to avoid adding other declaration function for the same functionnality with other arguments, I had the possibility to pass extra-arguments in a tuple of variadic templates. This enhancement could also be use to pass C++ objects such as vector, double
also translate french comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TST
class Plotis not testedMISC
According to numpy documentation: